Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Make clock tests less flaky #11

Open
jkuszmaul opened this issue Dec 20, 2017 · 0 comments
Open

Make clock tests less flaky #11

jkuszmaul opened this issue Dec 20, 2017 · 0 comments

Comments

@jkuszmaul
Copy link
Member

Currently the tests in util/clock_test.cc tend to be flaky because they they rely on the host machine actually executing the sleeps in a timely manner and not experiencing delays elsewhere.
There's a few things that should probably be done:

  • Separate out testing basic code functionality (does the code behave sanely) and performance testing (when running an X hz loop, how accurately do we hit the timing)
  • Adjust test environment to better match real applications (e.g., run processes at higher priorities)
  • Figure out good ways of measuring performance (e.g., currently we require every single of 100 iterations to be within some tolerance for time accuracy; maybe up that to 1000s of iterations and check that some percentage match our tolerances)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant