Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card component shouldn't have a default padding and a border #300

Open
3 of 15 tasks
brionmario opened this issue Oct 30, 2024 · 0 comments
Open
3 of 15 tasks

Card component shouldn't have a default padding and a border #300

brionmario opened this issue Oct 30, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@brionmario
Copy link
Member

brionmario commented Oct 30, 2024

Describe the issue:

There's a default padding & a border for the Card component from the default theme level.
This behaviour is inconsistent with the MUI behaviour since the content should be placed inside a CardContent component.

https://github.com/wso2/oxygen-ui/blob/559796f/packages/react/src/theme/default-theme.ts#L144-L145

How to reproduce:

  • Import the Card from @oxygen-ui/react/Card
  • See the padding & default border

Expected behavior:

  1. There shouldn't be any padding for the Card component.
  2. If users want a bordered card, they should use the variant="outlined"

Additional context :

  • Affected Package:
    • @oxygen-ui/logger
    • @oxygen-ui/primitives
    • @oxygen-ui/react
    • @oxygen-ui/react-icons
  • Library Version: [e.g., 1.10.0, 2.0.0-alpha]
  • OS:
    • Windows
    • Linux
    • Mac
    • Other
  • Browser:
    • Google Chrome
    • Firefox
    • Safari
    • Microsoft Edge
    • Brave
    • Opera
    • Other
@brionmario brionmario added the bug Something isn't working label Oct 30, 2024
@brionmario brionmario changed the title Card component shouldn't have a default padding Card component shouldn't have a default padding and a border Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant