Order of projects in Git and GitHub modules not consistant

[yelvert]

What's broken?

The order of the repos/projects in both the Git and GitHub modules changes every time wtfutil is restarted or the config file is reloaded.

For Git, I would expect the order of the repos to match the order of the array in the config file.
For GitHub, maybe the list of repos in the config file should be changed to an array, then display them in the module in that order.

[Seanstoppable]

@yelvert Are you using the map version of the config, or the list version for github? Maps in go do not guarantee order. I haven't seen this behavior using the list version.

For git, it looks like we are deliberately sorting alphabetically for some reason. I've opened a PR to review that behavior

[yelvert]

For git, I’m using a list, for github, a map.

…

On Sep 5, 2019, at 7:03 AM, Sean Smith ***@***.***> wrote: @yelvert Are you using the map version of the config, or the list version for github? Maps in go do not guarantee order. I haven't seen this behavior using the list version. For git, it looks like we are deliberately sorting alphabetically for some reason. I've opened a PR to review that behavior — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[Seanstoppable]

I'd switch to list for github. With a map there is no way to guarantee the order in the config will be the same as the order we end up with.

[yelvert]

I don’t remember off hand, but there was a reason I had to use a map. I’ll try a list though, and see if that works.

…

On Sep 5, 2019, at 11:37 AM, Sean Smith ***@***.***> wrote: I'd switch to list for github. With a map there is no way to guarantee the order in the config will be the same as the order we end up with. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[Seanstoppable]

Sounds good. If you have problems lemme know and we'll figure that part out too.

[senorprogrammer]

I've fixed the GitHub documentation to show the list ordering https://wtfutil.com/modules/github/

Between using a list for github, and PR #608 for git, repository ordering should now obey the configuration list order.