-
-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colors won't work for cmdrunner when using nodejs chalk or colorette library #618
Comments
See this issue for more details on why this is: #577 |
I tried giving FORCE_COLOR=1 as env variable but it seems chalk and colorette both failed to give NC character after they had it coloured. It'll be great if this is supported from cmdrunner instead. As both the libraries detects no support for color but on the other hand if I check for iTerm.app it seems to detect 256-bit color support for my current configuration. |
@abhayjatindoshi Can you give more details on how you are using this? I.e. what is your config? Have you tried wrapping this in a shell script and setting |
Thanks for the additional info! That is very interesting. Can you run Also, can you share more of the program you are testing with? |
I've made up a small zip for you. It contains 3 files.
Setting up is simple. unzip to your home folder and run either When you run the main.sh you'll see that color is set also for Shell outputCmdRunner output |
I THINK this is a bug in tview and potentially in chaulk. Note that the 2 scripts are not actually working the same. The shell script is clearing the style, and chaulk is setting the foreground color to the default (white) So chaulk is NOT clearing styles, so much as setting the default color. Tview doesn't handle default color, which I'll open a PR for. |
PR opened at rivo/tview#347 |
What's broken?
Colors won't work for cmdrunner when using nodejs chalk or colorette library
The text was updated successfully, but these errors were encountered: