Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parametrize AEM dirs #98

Open
krystian-panek-vmltech opened this issue Mar 7, 2023 · 4 comments
Open

Parametrize AEM dirs #98

krystian-panek-vmltech opened this issue Mar 7, 2023 · 4 comments
Labels
improvement Improvement to an existing feature

Comments

@krystian-panek-vmltech
Copy link
Contributor

krystian-panek-vmltech commented Mar 7, 2023 •
edited
Loading

imagine that aem setup is done in /opt/aem

then it is needed to launch aem cli in dir /opt as AEM CLI is looking for config file at relative path aem/home/etc/aem.yml

maybe instead

  • AEM_ROOT_DIR env var should be set to override aem relative path or...
  • AEM_HOME_DIR env var should be set to override aem/home relative path
@krystian-panek-vmltech krystian-panek-vmltech added improvement Improvement to an existing feature good first issue Good for newcomers and removed good first issue Good for newcomers labels Mar 7, 2023
@piotr-orwat-wttech
Copy link
Contributor

piotr-orwat-wttech commented Mar 10, 2023 •
edited
Loading

It would be nice to have also a flag ie. --config-path that provides a path to aem.yml file

@krystian-panek-vmltech
Copy link
Contributor Author

yep we need to add it; it should have a precedence over env var AEM_CONFIG_FILE

@krystian-panek-vmltech
Copy link
Contributor Author

the problem here is that some flag default value like for aem instance await --done-threshold is picked up from config and they are still overridable by CLI ...so this is sth like an egg and chicken problem - what should be initialized earlier... CLI app or the config. that's why currently AEM_CONFIG_FILE env var is the only way to change the aem.yml file location. IMO I am not sure if it's worth it to redesign the way how it is implemented now as it just works fine

@krystian-panek-vmltech
Copy link
Contributor Author

AEM_ROOT_DIR should be then used in SetDefault() methods in defaults.yml to propagate that value globally/correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@krystian-panek-vmltech @piotr-orwat-wttech