Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that session is valid before attempting to open #4

Open
wulfmann opened this issue Oct 2, 2020 · 2 comments
Open

Check that session is valid before attempting to open #4

wulfmann opened this issue Oct 2, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@wulfmann
Copy link
Owner

wulfmann commented Oct 2, 2020

The signin token creation process does not seem to actually require a valid session. So right now if you attempt to launch a session, it won’t fail until you get to the browser.

It may be worth adding a get_caller_identity call before creating the signin token to fail earlier.
@wulfmann wulfmann added enhancement New feature or request good first issue Good for newcomers labels Oct 2, 2020
@DanB288
Copy link

DanB288 commented Oct 4, 2020

Hey @wulfmann !! , I would like to work on this issue👍

@wulfmann
Copy link
Owner Author

wulfmann commented Oct 5, 2020

Sounds good @DanB288 let me know if you need any help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wulfmann @DanB288