Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDN s3 url not compatible with subdomains #1144

Closed
YassineElbouchaibi opened this issue Sep 4, 2024 · 5 comments
Closed

CDN s3 url not compatible with subdomains #1144

YassineElbouchaibi opened this issue Sep 4, 2024 · 5 comments
Labels
bug Something isn't working internally-reviewed The issue has been reviewed internally.

Comments

@YassineElbouchaibi
Copy link
Contributor

Hello, it seems like the added support for AWS S3 URLs for CDNs broke support for path style urls with nested subdomain (where hostname has more than 2 dots) e.g. minio.east.domain.com/mybucket.

A workaround is to set S3_ENDPOINT to the wanted origin and set the hostname in the s3 url to a dummy value without dots e.g. https://-/mybucket

Let me know if I missed something

Copy link

github-actions bot commented Sep 4, 2024

WunderGraph commits fully to Open Source and we want to make sure that we can help you as fast as possible.
The roadmap is driven by our customers and we have to prioritize issues that are important to them.
You can influence the priority by becoming a customer. Please contact us here.

@AndreasZeissner
Copy link
Contributor

Hi @YassineElbouchaibi thanks for pointing that out,

we are already working on the issue and will provide a fix.

@AndreasZeissner
Copy link
Contributor

Hi @YassineElbouchaibi,

#1145

it is on review.

@AndreasZeissner AndreasZeissner added bug Something isn't working internally-reviewed The issue has been reviewed internally. labels Sep 5, 2024
@AndreasZeissner
Copy link
Contributor

@YassineElbouchaibi
Copy link
Contributor Author

It works great, thanks for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internally-reviewed The issue has been reviewed internally.
Projects
None yet
Development

No branches or pull requests

2 participants