Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: delete org and user workflows #1326

Merged
merged 27 commits into from
Nov 22, 2024
Merged

fix: delete org and user workflows #1326

merged 27 commits into from
Nov 22, 2024
+7,654 −539

Conversation

thisisnithin
Copy link
Member

Motivation and Context

Checklist

@thisisnithin thisisnithin enabled auto-merge (squash) October 31, 2024 10:02
auto-merge was automatically disabled October 31, 2024 10:24

Pull request was closed

@thisisnithin thisisnithin reopened this Oct 31, 2024
@thisisnithin thisisnithin marked this pull request as draft October 31, 2024 10:26
@thisisnithin thisisnithin changed the title fix: set schema version as null on delete fix: delete graphs before deleting org Nov 5, 2024
@thisisnithin thisisnithin force-pushed the nithin/eng-5878-fix-federated-graph-schema-version-relation branch from 8bbaa60 to 862d419 Compare November 5, 2024 15:37
@thisisnithin thisisnithin marked this pull request as ready for review November 6, 2024 01:28
StarpTech
StarpTech requested changes Nov 11, 2024
View reviewed changes
controlplane/src/core/repositories/OrganizationRepository.ts Outdated Show resolved Hide resolved
controlplane/src/bin/delete-user.ts Outdated Show resolved Hide resolved
controlplane/src/bin/delete-user.ts Outdated Show resolved Hide resolved
controlplane/src/core/repositories/OrganizationRepository.ts Show resolved Hide resolved
@thisisnithin thisisnithin changed the title fix: delete graphs before deleting org fix: delete org and user workflows Nov 20, 2024
@thisisnithin thisisnithin enabled auto-merge (squash) November 22, 2024 11:01
StarpTech
StarpTech approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thisisnithin thisisnithin merged commit 484898d into main Nov 22, 2024
11 checks passed
@StarpTech StarpTech mentioned this pull request Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StarpTech StarpTech StarpTech approved these changes

Assignees
No one assigned
Labels
controlplane studio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thisisnithin @StarpTech