Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the timeouts for clickhouse and platform service #1500

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

JivusAyrus
Copy link
Member

Checklist

@github-actions github-actions bot added the cli label Jan 8, 2025
Copy link
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JivusAyrus JivusAyrus merged commit d425aa1 into main Jan 8, 2025
9 checks passed
@JivusAyrus JivusAyrus deleted the suvij/update-timeouts branch January 8, 2025 18:06
@YassineElbouchaibi
Copy link
Contributor

FYI this will make all future versions of the CLI incompatible with all controlplanes that are not on the current latest release. ConnectError: [invalid_argument] timeout 75000ms must be <= 30000

@StarpTech
Copy link
Contributor

@YassineElbouchaibi excellent catch! We were aware of that change and communicated it accordingly. Cosmo is still < v1 and it was a necessary change towards v1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants