Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Cache introspection query #155

Closed
vasek opened this issue Oct 5, 2023 · 4 comments
Closed

[Feature Request] Cache introspection query #155

vasek opened this issue Oct 5, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request internally-reviewed The issue has been reviewed internally.

Comments

@vasek
Copy link

vasek commented Oct 5, 2023

We have a large schema (~10MB, ~250.000 lines, ~10K types). The introspection query currently takes a couple seconds to responsd. It might be useful to cache the result of introspection (the router is aware when the schema changes so it's safe to do so).

@Aenimus Aenimus added the enhancement New feature or request label Oct 8, 2023
@jensneuse
Copy link
Member

It's a good idea and we've created an internal ticket to address it. Keeping you posted here.

@StarpTech StarpTech added the internally-reviewed The issue has been reviewed internally. label Mar 4, 2024
@StarpTech
Copy link
Contributor

Hi @vasek, we're starting to look into it. Are you able to provide a reproduction? (The artifact https://cosmo-docs.wundergraph.com/cli/router/fetch would help here a lot) Did you test the router in dev mode or production? In production, we have a plan cache. The cache is disabled when you use ART, which is enabled by default in dev mode. In the Studio, we no longer fetch the introspection data from the router; we fetch it from the schema registry. Please retest it with the latest versions. Nevertheless, there is still room for improvements but before we investigate further, we would like to know if it is still an impacts you. Thank you.

@StarpTech
Copy link
Contributor

I was able to reproduce with my own dataset.

@StarpTech
Copy link
Contributor

Closed in favor of #605

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internally-reviewed The issue has been reviewed internally.
Projects
None yet
Development

No branches or pull requests

5 participants