fix: error ordering for traces

connect/src/wg/cosmo/platform/v1/platform_pb.ts

@@ -125,6 +125,11 @@ export enum Unit {
    * @generated from enum value: SpanID = 7;
    */
   SpanID = 7,
+
+  /**
+   * @generated from enum value: Percentage = 8;
+   */
+  Percentage = 8,
 }
 // Retrieve enum metadata with: proto3.getEnumType(Unit)
 proto3.util.setEnumType(Unit, "wg.cosmo.platform.v1.Unit", [
@@ -136,6 +141,7 @@ proto3.util.setEnumType(Unit, "wg.cosmo.platform.v1.Unit", [
   { no: 5, name: "StatusCode" },
   { no: 6, name: "TraceID" },
   { no: 7, name: "SpanID" },
+  { no: 8, name: "Percentage" },
 ]);
 
 /**

controlplane/src/core/repositories/analytics/AnalyticsRequestViewRepository.ts

@@ -112,8 +112,12 @@ export class AnalyticsRequestViewRepository {
       unit: Unit.Nanoseconds,
       title: 'P95 Latency',
     },
-    errorsWithRate: {
-      title: 'Errors (Rate%)',
+    errors: {
+      title: 'Errors',
+    },
+    errorRate: {
+      title: 'Error Rate%',
+      unit: Unit.Percentage,
     },
     rate: {
       title: 'Rate',
@@ -289,12 +293,8 @@ export class AnalyticsRequestViewRepository {
             OperationType as operationType,
             sum(TotalRequests) as totalRequests,
             quantilesMerge(0.95)(DurationQuantiles)[1] as p95,
-            CONCAT(
-              toString(sum(TotalRequestsError)),
-              ' (',
-              toString(round(sum(TotalRequestsError) / sum(TotalRequests) * 100, 2)),
-              '%)'
-            ) as errorsWithRate,
+            sum(TotalRequestsError) as errors,
+            round(sum(TotalRequestsError) / sum(TotalRequests) * 100, 2) as errorRate,
             toString(toUnixTimestamp(max(LastCalled))) as lastCalled
           FROM
             ${this.client.database}.traces_by_operation_quarter_hourly
@@ -307,6 +307,7 @@ export class AnalyticsRequestViewRepository {
           ${baseOrderSql || 'ORDER BY totalRequests DESC'}
           ${basePaginationSql}
         `;
+
         break;
       }
       case AnalyticsViewGroupName.Client: {
@@ -316,12 +317,8 @@ export class AnalyticsRequestViewRepository {
             ClientVersion as clientVersion,
             sum(TotalRequests) as totalRequests,
             quantilesMerge(0.95)(DurationQuantiles)[1] as p95,
-            CONCAT(
-              toString(sum(TotalRequestsError)),
-              ' (',
-              toString(round(sum(TotalRequestsError) / sum(TotalRequests) * 100, 2)),
-              '%)'
-            ) as errorsWithRate,
+            sum(TotalRequestsError) as errors,
+            round(sum(TotalRequestsError) / sum(TotalRequests) * 100, 2) as errorRate,
             toString(toUnixTimestamp(max(LastCalled))) as lastCalled
           FROM
             ${this.client.database}.traces_by_client_quarter_hourly

proto/wg/cosmo/platform/v1/platform.proto

@@ -735,6 +735,7 @@ enum Unit {
   StatusCode = 5;
   TraceID = 6;
   SpanID = 7;
+  Percentage = 8;
 }
 
 enum AnalyticsViewFilterOperator {

studio/src/components/analytics/getColumnData.tsx

@@ -85,6 +85,10 @@ const formatColumnData = (data: string | number, type: Unit): ReactNode => {
     return <span>{mapStatusCode[data]}</span>;
   }
 
+  if (type === Unit.Percentage) {
+    return <span>{data}%</span>;
+  }
+
   if (type === Unit.TraceID || type === Unit.SpanID) {
     return (
       <TooltipProvider>

studio/src/components/analytics/metrics.tsx

@@ -583,7 +583,7 @@ export const ErrorMetricsCard = (props: {
         formatter={formatter}
         queryParams={{
           group: "OperationName",
-          sort: "errorsWithRate",
+          sort: "errors",
           sortDir: "desc",
         }}
         isSubgraphAnalytics={props.isSubgraphAnalytics}