We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Our project (https://github.com/wunderio/client-fi-thl-innokyla) started failing phpcs validation as a result of drupal/coder update from 8.3.6 to 8.3.7 (it started including file extension that used to be excluded). Looking at the diff (https://git.drupalcode.org/project/coder/compare/8.x-3.6...8.x-3.7) I'm assuming the culprit is https://git.drupalcode.org/project/coder/commit/69b071b610803080e8ac1ca6757ed4e64524171c for issue https://www.drupal.org/node/3074176 where the default file extensions were removed from the rulesets. Not sure if there's anything we can do about it here other than maybe document the change? Anyway adding this to our local phpcs.xml seems to return proper file extensions:
drupal/coder
phpcs.xml
<!-- Set default file extensions --> <arg name="extensions" value="php,module,inc,install,test,profile,theme,css,info,txt,md,yml"/>
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Our project (https://github.com/wunderio/client-fi-thl-innokyla) started failing phpcs validation as a result of
drupal/coder
update from 8.3.6 to 8.3.7 (it started including file extension that used to be excluded). Looking at the diff (https://git.drupalcode.org/project/coder/compare/8.x-3.6...8.x-3.7) I'm assuming the culprit is https://git.drupalcode.org/project/coder/commit/69b071b610803080e8ac1ca6757ed4e64524171c for issue https://www.drupal.org/node/3074176 where the default file extensions were removed from the rulesets. Not sure if there's anything we can do about it here other than maybe document the change? Anyway adding this to our localphpcs.xml
seems to return proper file extensions:The text was updated successfully, but these errors were encountered: