Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drupal/coder 8.3.7 affecting default file extensions #42

Open
wktohesi opened this issue Dec 17, 2019 · 0 comments
Open

drupal/coder 8.3.7 affecting default file extensions #42

wktohesi opened this issue Dec 17, 2019 · 0 comments

Comments

@wktohesi
Copy link

Our project (https://github.com/wunderio/client-fi-thl-innokyla) started failing phpcs validation as a result of drupal/coder update from 8.3.6 to 8.3.7 (it started including file extension that used to be excluded). Looking at the diff (https://git.drupalcode.org/project/coder/compare/8.x-3.6...8.x-3.7) I'm assuming the culprit is https://git.drupalcode.org/project/coder/commit/69b071b610803080e8ac1ca6757ed4e64524171c for issue https://www.drupal.org/node/3074176 where the default file extensions were removed from the rulesets. Not sure if there's anything we can do about it here other than maybe document the change? Anyway adding this to our local phpcs.xml seems to return proper file extensions:

<!-- Set default file extensions -->
<arg name="extensions" value="php,module,inc,install,test,profile,theme,css,info,txt,md,yml"/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant