Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still having the iconv issue #43

Open
hkirsman opened this issue Feb 13, 2020 · 1 comment
Open

Still having the iconv issue #43

hkirsman opened this issue Feb 13, 2020 · 1 comment

Comments

@hkirsman
Copy link
Collaborator

You might not notice it because composer installs older version of code-quality if requirements are met.

I checked that on my system I have iconv.so but it's just not loaded.

One way to overcome this is enable it on shell:

php -d extension=iconv.so /bin/composer require wunderio/code-quality:1.0.5 --dev

Not ideal but could we use this info somehow to automate this?

@hkirsman
Copy link
Collaborator Author

A little bit smarter would be to detect the location of composer. So rewriting the original command we have in readme from

composer require wunderio/code-quality --dev

to

php -d extension=iconv.so $(which composer) require wunderio/code-quality --dev

Would at least try to load the extension. If it's not there, it will give warning but continues so no harm done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant