Tests and fix for #94 #96
Conversation
|
@wvanbergen I can't really follow the code deep within the QueryBuilder sadly :-(. Especially in the core table / column quoting areas which this will touch. Want to take a look? I will when I have more time. |
|
I am on vacation and won't have time to look at it until august. Sent from my iPhone
|
| Moo.create!(:foo => 'foo too', :primary_ham => @ham1) | ||
| Moo.create!(:foo => 'foo three', :primary_ham => @ham2) | ||
| Moo.create!(:foo => 'foo four', :secondary_ham => @ham2) | ||
| Moo.create!(:foo => 'foo four', :primary_ham => @ham1, :secondary_ham => @ham2) |
There was a problem hiding this comment.
I find having two lines with 'foo four' confusing, it is hard to understand the test with so many data line can you please reduce it?
|
I suppose this one got lost somewhere in 2014, closing for now. If you'd like to get this in, please reopen. |
Starting branch to fix #94. I have a failing test to start with.