Show a specific error for an unintended "not null" query #223
Conversation
|
Ugh. I wasn't able to run the tests locally (except for the SQLite ones). I will fix this quoting issue... |
Gemfile
Outdated
| @@ -16,4 +16,5 @@ platforms :ruby do | |||
| gem 'sqlite3' | |||
| gem 'mysql2' | |||
| gem 'pg' | |||
| gem 'mutex_m' | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
It looks as though I could move this into just the 6.0 and 6.1 variants of the gemfile. Not sure if that's the right way or not.
|
Can you advise me how to configure the GH actions so I can run these on my account? Trying to peck at this, but fixing one error shows me another one. |
|
If you look at the last run, there's a ruby standard library removal that's being tripped at certain points. A bunch of the tests are failing because that library is now bundled as a gem, not part of the StdLib. This may not be the correct place to add it, I have not yet dug into the individual ruby version gem files yet, and I imagine I should. Since I can't run the tests locally in a way that triggers this error, I am kinda whacking moles in the dark here.
Walter
… On Jul 16, 2024, at 11:50 AM, Adam Růžička ***@***.***> wrote:
@adamruzicka commented on this pull request.
In Gemfile:
> @@ -16,4 +16,5 @@ platforms :ruby do
gem 'sqlite3'
gem 'mysql2'
gem 'pg'
+ gem 'mutex_m'
Why?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
If you open a pull request from your fork against your fork, it maybe could run the tests? Or at least it seems to do so for me. Alternatively, if you're on matrix, feel free to reach out to me (@aruzicka:matrix.org) tomorrow, I might be able to help you to get the tests to run locally |
|
I didn't have any time to look at this today, but I did sign up at matrix. I am @waltd:matrix.org. What time zone are you in? I am in EDT. I tried getting the runners to go on my fork, but I have never set any of that stuff up in this account, and the only available option seemed to be the self-hosted runner. Is that what you use? |
The same error and message is used for many different ambiguous query compositions. In the case of the
haskeyword, it's such a common part of speech that it could inadvertently creep into a naïve query: "walter has a big nose" might throw the same error (unless you have a column in your database nameda) as many other cases. This makes it difficult to understand, since that generic error message is designed to serve so many purposes.This PR introduces a specific error to be used for a missing or unmatched field, and the error message includes both the parent class and the specific token which has been interpreted as a field name by the query builder.