Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

surface (internal): Use .typeMember instead of .tree to get parameter types #3466

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

OndrejSpanel
Copy link
Contributor

@OndrejSpanel OndrejSpanel commented Mar 22, 2024

Do not use .tree to obtain parameter types, use typeMember instead. The code is simpler and more reliable, avoiding issue scala/scala3#19795 (#3417)

@xerial xerial added the internal Internal changes (usually non-user facing) label Mar 22, 2024
@xerial xerial changed the title Use .typeMember instead of .tree to get parameter types surface (internal): Use .typeMember instead of .tree to get parameter types Mar 22, 2024
@xerial xerial merged commit 451eaf2 into wvlet:main Mar 22, 2024
15 checks passed
@xerial
Copy link
Member

xerial commented Mar 22, 2024

Thanks for the improvement. Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal changes (usually non-user facing)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants