Fix wrapper tag #272
Merged
Fix wrapper tag #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Babel's react-jsx preset treats low-case tags as
literal elements, not as a variables.
So, for jsx:
<wrapper ... />
It generates js:
React.createElement('wrapper')
But we want:
React.createElement(wrapper)
Changing case of variable fixes the issue
React.createElement expects string or React.Component in first argument. React.DOM.div and React.DOM.span are neither strings nor Components. They are wrappers around React.createElement. Also, they are deprecated. Read more: https://facebook.github.io/react/docs/react-api.html#createelement For our case, we could safely pass strings to React.createElement, so, no need to use React.DOM.div etc
|
Was planning on doing this, already forked the repo, Thanks and sorry. |
|
@MatanBobi, oh, I'm so sorry, this fix is really yours! Henceforth, let us know in advance, please! I'm sorry! I haven't noticed that you have created repository just yesterday... |
|
@huumanoid its not your fault at all, It was a minor fix, definitely my bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR related to #211
After applying #211, the wrapper DOM element for
ReactTooltipexpected to be<div>or<span>, but actually it's a<wrapper>:The reason of this behavior described by @MatanBobi here, and some more details are in c37e063 commit message.
Another issue is that we can't pass
React.DOM.divtoReact.createElement, we should pass'div'instead. Read more: 3c85424Thanks @dropfen for #211 and for his concern about backward compatibility.
Thanks @MatanBobi for his report and investigation.
Thanks @wwayne for awesome
ReactTooltiplibrary.