Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute or enrich tip content #360

Merged
merged 1 commit into from
May 15, 2018
Merged

Compute or enrich tip content #360

merged 1 commit into from
May 15, 2018

Conversation

austil
Copy link
Contributor

@austil austil commented Jan 3, 2018

Hi, for a specific use case I needed to compute the tip content at runtime based on the data-tip's attribute value, so here we go.

PS : I may have interests in maintaining the project 😉

@aronhelser
Copy link
Collaborator

This makes perfect sense to me. Then each target could actually just have data-tip={id} that lets the getContent(dataTip) method identify which element it is.

BTW, @austil I would be happy for any help you would care to give in maintaining, if you are interested.

@phileveritt
Copy link

Any chance of getting this merged? This is exactly the change I'm after. Rather than creating a tooltip per object I'd like a single one and have the getContent method to decide on how to generate the tt information based on the target.

@austil
Copy link
Contributor Author

austil commented May 15, 2018

Conflicts on this pull request are weird, I should probably submit a new one (changes are fairly simple), ready to merge.

@aronhelser I will be happy to help. What are your thought on the build system (compared to stuff like webpack) and "test galery" (compared to a shiny storybook) of this project ?

@aronhelser
Copy link
Collaborator

@austil either resolving the conflicts here or in a new PR are both fine.
I'm more familiar with webpack, so I'd be happy with a switch to that. I'm not sure about the style bundling, though. A better place for a "test gallery" would also be welcome.

@austil austil closed this May 15, 2018
@austil austil reopened this May 15, 2018
@austil
Copy link
Contributor Author

austil commented May 15, 2018

Some refactoring was made on the part concerned by my changes so I had to do a new commit (while deleting the previous ones with a dirty head reset followed by a force push).
It is now ready to merge 😉

@aronhelser aronhelser merged commit e56cf3e into ReactTooltip:master May 15, 2018
@aronhelser
Copy link
Collaborator

🎉 This PR is included in version 3.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@phileveritt
Copy link

thank you both for working on this and getting it merged - it's a great addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants