Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mouseover): Add ability to hover on tooltip. #416

Merged
merged 2 commits into from
Sep 3, 2018

Conversation

RobertGary1
Copy link

Provide optional delay of updating so if the mouse path into the tooltip crosses another target the contents don't change. This feature allows you to put menus in tooltips, etc.

issue 411

@vireshshah
Copy link

@wwayne @RobertGary1 Any timeline to merge this PR? I think we need similar feature.

@aronhelser
Copy link
Collaborator

This is a great idea, and I like the example, it works well.

Unfortunately, on Windows Chrome, I get an error in the "Update tip content over time" and "Test Scrolling" sections:
Uncaught TypeError: Cannot set property 'intervalUpdateContent' of undefined
at ReactTooltip. (index.js:330)
at commitCallbacks (react-dom.development.js:6544)
....

@RobertGary1 or @vireshshah if you can look and resolve, we can get this merged - otherwise you'll have to wait for me to investigate, which unfortunately may take a while...

@RobertGary1
Copy link
Author

Oh, I'm sorry. I see the issue. Should be a quick fix.

Fix an issue in my first commit that caused a dereference of the incorrect "this" object.
@vireshshah
Copy link

Awesome. Thanks a lot, @RobertGary1 @aronhelser. If everything looks good then can we merge it? As I mentioned, we're waiting eagerly for this fix. Thanks!

@aronhelser aronhelser merged commit 9617aa7 into ReactTooltip:master Sep 3, 2018
@aronhelser
Copy link
Collaborator

🎉 This PR is included in version 3.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@vireshshah
Copy link

Thanks a lot @aronhelser @RobertGary1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants