-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EasyEffects systemd service instance is exited when quitting another instance #1310
Comments
Tried on e13f757 and I'm not able to reproduce the issue. |
Could it be that |
No, it's disabled. |
There is something odd in your installation. I have been using the master branch everyday for a few weeks and I do not have in my logs the errors I see in yours
I have never seen any of them. One of the first things I did in the master branch was using |
What happens if you run |
I had a stray settings.ini with
The same behaviour happens. |
One notable difference is that the second instance on 6.1.5 outputs this on quit:
Seemingly the master version exits with an error instead, assuming that's what status 1 means. I'm currently bisecting, will comment more when I figure out where it begins. |
I'm a bit confused that I landed on 7bf78ac as first bad commit, since it's before the 6.1.5 tag. After that commit, the PID running with |
I had an It seems to me that the only version of EasyEffects behaving properly on your system are the ones based on gtkmm. Now that we use gtk4 directly something that is different on your system may be triggering some kind of gtk4 bug. It is looking like one of those odd situations where gtk misbehaves outside of GNOME =/ |
When EasyEfects receives the command line option to start as a service we call easyeffects/src/application.cpp Line 237 in 7f88daa
|
It is a known thing that gtk4 and sway have some incompatibilities. But I do not see how the desktop could be having such a side effect on gtk. |
So I ended up on the same commit on the second bisect. However I did test on X11 + AwesomeWM and the issue is present depending on how I close the window. However if I Ctrl+Q, it is exited. Logs: The second instance is at log line |
That is the expected behavior. |
I can indeed get the correct behaviour by using the app close button even on Sway. So not sure if there's still an issue here. |
Oh! I see. This is a new behavior we did not have before. If you were testing with |
Oh well, I guess I learned about Ctrl+W after all of this. |
I think we can close this. |
I'm having the same problem, I don't think Ctrl+W is the solution, I mean If the option exists "Shutdown on window close", thereafter if I click the Window X button It shouldn't disable it, the app does not get killed but the service seems not to apply the configuration until I re-open the app. |
That option was added to cover a very specific corner case and for many times I considered removing it. Some people want the service to be finished when they close the window. Independently of how they are closing the window. What is not possible under normal circumstances when EasyEffects is started as a service. That option exists only to allow that. The only difference in the next release is that the meaning of |
EasyEffects Version
6.2.0
easyeffects-git 6.1.5.r268.g7f88daa6-1
What package are you using?
AUR (easyeffects-git)
Distribution
Arch Linux
Describe the bug
Similar to #1215, except I'm not using Flatpak.
Running Sway 1.6.1.
When I have
easyeffects
running in the background, and I launch anothereasyeffects
instance (for the GUI), both are exited when I close the new one.Closing with Ctrl+Q.
I tried building from the AUR
easyeffects-git
package as well as the PKGBUILD from the git, both end up with the same result.As far as I'm aware, this is a regression because it used to work correctly.
Expected Behavior
The instance running as a service should keep running, but it's exiting cleanly instead.
Since the service is set to restart on failure, it's never restarted.
Debug Log
Debug Log
For this log, I started the systemd service, another instance and waited a couple seconds before closing it.
Second instance debug log
Additional Information
My systemd service starts at boot (and login)
I debugged with this service file:
Also, the exit log from the 2nd instance is printed right at launch.
But the PID that exits is indeed the newly launched program, not the running service.
Will look into bisecting a bit later.
The text was updated successfully, but these errors were encountered: