32 add support for other international numbers guest invite #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebasing branch
Added dropdown for international number and updated the regex and input mask to match.
askmrsinh
requested changes
Sep 19, 2023
There was a problem hiding this comment.
Thanks @wmpmills!
Looks good for the most part. However, the input number field is much smaller now, due to which some of the input digits will appear hidden.
Would you mind making some adjustments so that this doesn't happen? Some things that I would try:
- switching the two column layout to a single column and adding the button as another field addons (just like you did for the dropdown).
- Dropping the Flag emoji?
- Dropping the Country Code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@askmrsinh , please review this PR when you can.