Ensure that existing blockParams and depths are respected on dupe programs #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -714,12 +714,14 @@ JavaScriptCompiler.prototype = { | |||
|
|
|||
| this.useDepths = this.useDepths || compiler.useDepths; | |||
| this.useBlockParams = this.useBlockParams || compiler.useBlockParams; | |||
| child.useDepths = this.useDepths || compiler.useDepths; | |||
| child.useBlockParams = this.useBlockParams || compiler.useBlockParams; | |||
There was a problem hiding this comment.
We don't need the || conditions here, it's already been done in the lines above.
|
Thanks. One minor nit and otherwise this looks great. |
charleso
force-pushed
the
bugfix/1186-existing-program-block-param
branch
from
7462ccd
to
c7be766
Compare
|
@kpdecker Good point. Updated. |
kpdecker
added a commit
that referenced
this pull request
Mar 7, 2016
…lock-param Ensure that existing blockParams and depths are respected on dupe programs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1186
I'm opening this partly just to help identify the problem, my knowledge of the internals of
handlebars.jsis non-existent and there may well be more desirable ways to fix this problem.I believe underlying cause is that the previous
compiler.useBlockParamsis not respected for any subsequent existing programs that are matched. I've just set/stashed/slashed/hacked the value on tochildenvironment, but this is the part that may need to be done differently.Question - how much performance does matching/re-using the existing programs save? (Just curious)