Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Uglifier with harmony in order to allow ES6 syntax. #2227

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

jhanggi
Copy link
Contributor

@jhanggi jhanggi commented Feb 24, 2020

Release Notes

Tech task: Allow ES6 syntax in JS.

Additional Context

This error came up on open stage: Uglifier::Error: Unexpected token: keyword (const). To use ES6 syntax, harmony mode must be enabled with Uglifier.new(:harmony => true)

@jhanggi jhanggi requested a review from a team February 24, 2020 20:55
@jhanggi jhanggi requested a review from a team as a code owner February 24, 2020 20:55
@jhanggi
Copy link
Contributor Author

jhanggi commented Feb 24, 2020

Separately, we should assess if Uglifier has fixed this bug: mishoo/UglifyJS#3245

We're currently locked down to an older version.

@jhanggi jhanggi merged commit 054e33c into master Feb 24, 2020
@jhanggi jhanggi deleted the use_es6_uglifier branch February 24, 2020 22:31
joshea0 pushed a commit to SquaredLabs/nucore-uconn that referenced this pull request Mar 18, 2020
# Release Notes

Tech task: Allow ES6 syntax in JS.

# Additional Context

This error came up on open stage: `Uglifier::Error: Unexpected token: keyword (const). To use ES6 syntax, harmony mode must be enabled with Uglifier.new(:harmony => true)`
chrixp pushed a commit to SquaredLabs/nucore-uconn that referenced this pull request Oct 21, 2020
# Release Notes

Tech task: Allow ES6 syntax in JS.

# Additional Context

This error came up on open stage: `Uglifier::Error: Unexpected token: keyword (const). To use ES6 syntax, harmony mode must be enabled with Uglifier.new(:harmony => true)`
joshea0 pushed a commit to SquaredLabs/nucore-uconn that referenced this pull request Oct 23, 2020
# Release Notes

Tech task: Allow ES6 syntax in JS.

# Additional Context

This error came up on open stage: `Uglifier::Error: Unexpected token: keyword (const). To use ES6 syntax, harmony mode must be enabled with Uglifier.new(:harmony => true)`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants