Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No animations for most recent angular versions? #73

Closed
HannesJo0139 opened this issue Feb 19, 2021 · 5 comments
Closed

No animations for most recent angular versions? #73

HannesJo0139 opened this issue Feb 19, 2021 · 5 comments

Comments

@HannesJo0139
Copy link
Contributor

HannesJo0139 commented Feb 19, 2021

Sorry for asking here but I cannot find another place to do so. I try to implement ngx-masonry in my angular 11 project and everything works except for animations. If an element changes size or so, it just "jumps" but there is no animation at all. Therefore I tried to do a minimum setup based on your demo wynfred/ngx-masonry-demo. The hosted version is animated (Eg when triggering re-arrangement die to window resize) but seem to use angular8. So I cloned it to my local machine and there are also no animations. Do I miss somethin or are animations broken?

@wynfred
Copy link
Owner

wynfred commented Feb 23, 2021

Hi, the core masonry lib does support animation but it has many issues (you can try version v1.x). The animation implemented in this library is only for showing the items.

@HannesJo0139
Copy link
Contributor Author

HannesJo0139 commented Feb 23, 2021

Thanks for your reply. So this is related to #8? That was not clear to me.
However, css transition property like

.masonry-item {
  transition: top 0.4s ease-in-out,  left 0.4s ease-in-out;
}

seems to work very well. Or do U see any problem with that? Maybe you could add a hint to the readme animation section on what animations work out of the box and what do not - or I may send a pull request adding that information?

@wynfred
Copy link
Owner

wynfred commented Feb 23, 2021

Yes, animation was re-implemented because of #8

Looks good. Feel free to open a PR. Thanks!

@HannesJo0139
Copy link
Contributor Author

See #74

@wynfred
Copy link
Owner

wynfred commented Feb 24, 2021

:shipit:

@wynfred wynfred closed this as completed Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants