-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INVALID_VALUE: texImage2D: no canvas #910
Comments
If interested you can find d3-x3dom here: |
I did some tracing using the dev tools debugger.
This causes then nothing to be rendered on the canvas which is used as a texture for the text which caueses the console error. It should be harmless but probably worth checking why the no content text node is generated in the first place. |
@andreasplesch you genius! Thank you! I will fix this bug in d3-x3dom! btw If you(or anyone) have any comments, tips or ideas for d3-x3dom I would love to hear them. At the very least I created it to promote x3dom! |
The spec. does not have any specific guidance on what to do if the string is empty. I think it would be best to return early from updateText: https://github.com/x3dom/x3dom/blob/master/src/Texture.js#L425 as then there is nothing to do. It would be a reasonable fix. On the other hand, Firefox is not complaining anyways, only Chrome is. It might be worth checking Edge. Another first step would be to find out what the WebGL spec. says should be done if a canvas is empty, as passed to gl.texImage2D(). Chrome thinks it is INVALID but perhaps it is not as FF does not mind. |
I have been developing a D3.js + X3DOM chart library d3-x3dom. I often see the following console warnings on Chrome but have no idea why?
These errors can be seen on the following example:
https://jamesleesaunders.github.io/d3-x3dom/examples/BarChartMultiSeries.html
Is there something I have done wrong in d3-x3d or should I not be concerned? It does not seem to have any effect on the result.
The text was updated successfully, but these errors were encountered: