Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac Layout Issue #4

Closed
Blackglade opened this issue May 25, 2014 · 8 comments
Closed

Mac Layout Issue #4

Blackglade opened this issue May 25, 2014 · 8 comments

Comments

@Blackglade
Copy link

I installed this awesome theme on my Mumble OSX Client and there is a bit of an issue...

Nothing too major but the weird (slightly ugly) gradient top bar doesn't go away!

Any Fix?

test

@xpoke
Copy link
Owner

xpoke commented May 25, 2014

Heya,
I don't have OSX myself so this is hard for me to test.

Knowing QT skinning, this is probably something I can't fix like I would like to.
I did a small fix to at least have the toolbar transparent so it'll look normal. Try downloading the latest source, let me know if it helped.

@xpoke xpoke closed this as completed in 834da23 May 25, 2014
@xpoke xpoke reopened this May 25, 2014
@Blackglade
Copy link
Author

Well it definitely looks much better! Thanks for the help!
test

@xpoke
Copy link
Owner

xpoke commented May 25, 2014

Cheers :)
Not 100% pleased with the result though, and I'm pretty sure if you'll press the mute button it'll look funky...
I can only suggest using the lite theme on OSX, but at least it's somewhat passable. Leaving this open for now anyway.

@xpoke
Copy link
Owner

xpoke commented May 25, 2014

Hey, I've found a possible solution on the qt bug reports.
https://bugreports.qt-project.org/browse/QTBUG-12717

Please let me know if the bar is now colored properly!

@Blackglade
Copy link
Author

Unfortunatly... I don't think it made the difference :(

test

@xpoke
Copy link
Owner

xpoke commented May 29, 2014

Hey,
After looking around, it seems this issue can't be solved as far as the skin is concerned.
QSS alone simply doesn't allow to bypass QT's native menubar on OSX.

Mumble itself could add a way to bypass this from their side, perhaps an OSX-only checkbox in the options to choose between native menubar and QT menubars.

Otherwise, it's a QT issue and I can't fix it without breaking something else in the skin on another OS...

@Blackglade
Copy link
Author

It's quite alright, I appreciate the effort! Would you mind then reverting the repo back to the original OSX fix your proposed which was backing the background transparent?

@xpoke
Copy link
Owner

xpoke commented May 30, 2014

Most of the effort was googling and cussing QT, which is a normal day really :)

As I said, it breaks the toolbar on non-OSX clients (when dragging and dropping), so i added a separate qss file for OSX users, which will do for now.

xpoke added a commit that referenced this issue May 30, 2014
Added separate OSX qss files to allow a transparent menubar
#4
xpoke added a commit that referenced this issue May 30, 2014
Added separate qss files for OSX to allow transparent toolbar (native OSX)
As per #4
@xpoke xpoke closed this as completed May 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants