Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Bearded Theme - Color Inconsistencies and Inactive Lines #1

Open
ahmedreda1009 opened this issue May 3, 2024 · 7 comments

Comments

@ahmedreda1009
Copy link

ahmedreda1009 commented May 3, 2024

Feedback on Bearded Theme for Neovim

I hope this message finds you well. Firstly, I wanted to express my appreciation for your work on the Bearded Theme for Neovim. It's been a delightful addition to my coding environment, reminiscent of the setup I enjoyed while using VSCode.

As I've transitioned to Neovim and adopted the Bearded Theme, I've encountered a couple of issues that I believe are worth addressing:

Color Differences between Neovim and VSCode

Upon comparing files opened in Neovim with the Bearded Theme and VSCode with the Bearded Theme, I've noticed discrepancies in color representation, particularly in React and .tsx files. Ensuring consistency across different editors is crucial for maintaining a seamless workflow, and resolving these color inconsistencies would greatly enhance user experience.

Indent Guides

The lines that link the beginning and end of brackets, such as parentheses, braces, and square brackets. Similarly, in HTML files, these lines connect the opening and closing tags. While these lines do change color when the cursor is on them in all Neovim themes to indicate where I am in the code, they don't become active as expected. Instead, they remain static, which can lead to confusion and detracts from their utility in code navigation.

I hope this clarification helps in addressing the issues more effectively. Your attention to these matters would greatly contribute to improving the overall usability and aesthetics of the Bearded Theme.

Thank you for your dedication to maintaining and enhancing this excellent theme. I eagerly await your response and any updates you may provide.

@xStormyy
Copy link
Owner

xStormyy commented May 4, 2024

Thank you for the feedback!

I will try to fix the inconsistencies between languages.

Although i'm a bit confused when you mentioned the inactive lines for bracket beginnings and endings, could you maybe send an example?

Also, are there any other variants (outside of vivid) you would want added?

@ahmedreda1009
Copy link
Author

ahmedreda1009 commented May 5, 2024

I'm referring to the indent lines, like the ones showcased in the image below:
image

Ideally, when the cursor is placed within a function, the lines indicating the start and end of that function should become active. However, this isn't occurring as expected.
Regarding the other variants, I'm not sure as I primarily use the vivid black only in this theme and There might be some occasional use of the vivid purple, but it's quite rare for me.

@xStormyy
Copy link
Owner

xStormyy commented May 5, 2024

I see what you mean now. do you mind telling me which plugin you use for the indent lines? I probably just need to add support for plugins that add those.

@ahmedreda1009
Copy link
Author

I use Lazyvim distro and I think they use indent-blankline and mini.indentscope to handle it.

@xStormyy
Copy link
Owner

xStormyy commented May 8, 2024

Hello! I'm sorry for the kind of wait, but I think I might have sorted out the indent-blankline and indentscope issue, although i'm not entirely sure, so I would appreciate some feedback on it.

When it comes to the consistencies between different syntaxes, I would still need to see if I can do anything.

@ahmedreda1009
Copy link
Author

thanks for the effort. I will check it and give you a feedback.

@ahmedreda1009
Copy link
Author

I have just checked it in some js, ts, jsx, tsx files but I have noticed that unfortuneatly everything is the same as before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants