Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Android - Fix for losing focus in Editor when Table View's Table Section Changes #11518

Closed
wants to merge 5 commits into from

Conversation

mjmostachetti
Copy link
Contributor

Description of Change

On Android, the Editor won't lose focus after changing the Title in a Table Section.

On iOS, it seems like Editing Ended is called from external code when a change is made to the Table Section's Title. I'm not sure about a fix for this. Any thoughts?
Screenshot 2020-07-22 at 10 38 29 PM

Issues Resolved

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

Described above.

Before/After Screenshots

Not applicable

Testing Procedure

I added a class Issue9618.cs that demonstrates the fix for Android.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@dnfadmin
Copy link

dnfadmin commented Jul 23, 2020

CLA assistant check
All CLA requirements met.

Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on Android with your changes and without and i see the same thing. I always get the editor showing up.

@mjmostachetti
Copy link
Contributor Author

mjmostachetti commented Jul 29, 2020

Right. The keyboard is visible with and without my code changes. The subtle difference is that with the code changes you don't lose the highlight and the cursor in the editor. The keyboard is definitely visible and typing still works in both cases. I'm guessing this is what the user was bringing up in their issue?
Without Changes -
without_changes
With Changes -
with_changes

@samhouts samhouts changed the base branch from 4.7.0 to 5.0.0 August 4, 2020 21:16
@samhouts samhouts added this to the 5.0.0 milestone Aug 4, 2020
@mjmostachetti
Copy link
Contributor Author

@rmarinho What should I do here? It seems like the bug is a minor issue w/ losing the highlight and the cursor disappearing.

@rmarinho
Copy link
Member

/azp run

@xamarin xamarin deleted a comment from azure-pipelines bot Aug 17, 2020
@PureWeen PureWeen modified the milestones: 5.0.0, 5.0.1 Nov 5, 2020
@jfversluis
Copy link
Member

Now that we're so close to the sunsetting of Xamarin.Forms unfortunately we won't be able to take this in anymore, we're really sorry about that. Nevertheless, thank you so much for your time and effort that you have put into this PR.

Please have a look at the evolution of Xamarin.Forms, .NET MAUI. A lot of development has been going on there. Hopefully this issue was already fixed in that codebase. If not, feel free to port this over to there.

Again, thank you so much for being a contributor and Xamarin.Forms user!

@jfversluis jfversluis closed this Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/listview Problems with the ListView/TableView p/Android t/bug 🐛
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Changing Text of TableSection changes focus.
8 participants