From 4dc96f8b85b153398c8cb00493bd9977290544a3 Mon Sep 17 00:00:00 2001
From: Mikayla Hutchinson <m.j.hutchinson@gmail.com>
Date: Fri, 1 Sep 2017 15:40:49 -0400
Subject: [PATCH] Fix default items

There were some issues in the MSBuild evaluation order
that caused the default items files to never get used.
---
 .nuspec/Xamarin.Forms.DefaultItems.props   | 2 +-
 .nuspec/Xamarin.Forms.DefaultItems.targets | 2 +-
 .nuspec/Xamarin.Forms.props                | 2 +-
 .nuspec/Xamarin.Forms.targets              | 3 +--
 4 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/.nuspec/Xamarin.Forms.DefaultItems.props b/.nuspec/Xamarin.Forms.DefaultItems.props
index cb948d9cbca..7df69df5412 100644
--- a/.nuspec/Xamarin.Forms.DefaultItems.props
+++ b/.nuspec/Xamarin.Forms.DefaultItems.props
@@ -1,6 +1,6 @@
 <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
 
-	<ItemGroup>
+	<ItemGroup Condition="'$(EnableDefaultItems)'=='True' And '$(EnableDefaultXamlItems)'=='True' And '$(EnableDefaultEmbeddedResourceItems)'=='True'">
 		<EmbeddedResource Include="**\*.xaml" Exclude="$(DefaultItemExcludes);$(DefaultExcludesInProjectFolder)" SubType="Designer" Generator="MSBuild:UpdateDesignTimeXaml" />
 	</ItemGroup>
 
diff --git a/.nuspec/Xamarin.Forms.DefaultItems.targets b/.nuspec/Xamarin.Forms.DefaultItems.targets
index d41993f7c4d..d19252a595b 100644
--- a/.nuspec/Xamarin.Forms.DefaultItems.targets
+++ b/.nuspec/Xamarin.Forms.DefaultItems.targets
@@ -7,7 +7,7 @@
 	Unfortunately there is no way to work around this without adding a new extension point to
 	the sdk props.
 	-->
-	<ItemGroup>
+	<ItemGroup Condition="'$(EnableDefaultItems)'=='True' And '$(EnableDefaultXamlItems)'=='True' And '$(EnableDefaultEmbeddedResourceItems)'=='True'">
 		<Compile Update="**\*.xaml$(DefaultLanguageSourceExtension)" DependentUpon="%(Filename)" SubType="Code" />
 		<None Remove="**\*.xaml" Condition="'$(EnableDefaultNoneItems)'=='True'" />
 	</ItemGroup>
diff --git a/.nuspec/Xamarin.Forms.props b/.nuspec/Xamarin.Forms.props
index b2dcced2d51..54c037276a4 100644
--- a/.nuspec/Xamarin.Forms.props
+++ b/.nuspec/Xamarin.Forms.props
@@ -10,6 +10,6 @@
 	The actual item groups are in a separate conditionally-imported file as they use constructs that
 	are not compatible with older MSBuild versions.
 	-->
-	<Import Project="$(MSBuildThisFileDirectory)Xamarin.Forms.DefaultItems.props" Condition="'$(_DefaultXamlItemsEnabled)'=='True'" />
+	<Import Project="$(MSBuildThisFileDirectory)Xamarin.Forms.DefaultItems.props" Condition="'$(MSBuildSDKsPath)'!=''" />
 
 </Project>
diff --git a/.nuspec/Xamarin.Forms.targets b/.nuspec/Xamarin.Forms.targets
index 37959c40712..fe8a4d49ef1 100644
--- a/.nuspec/Xamarin.Forms.targets
+++ b/.nuspec/Xamarin.Forms.targets
@@ -6,10 +6,9 @@
 	<PropertyGroup>
 		<EnableDefaultXamlItems Condition="'$(EnableDefaultXamlItems)'==''">True</EnableDefaultXamlItems>
 		<_DefaultXamlItemsEnabled>False</_DefaultXamlItemsEnabled>
-		<_DefaultXamlItemsEnabled Condition="'$(EnableDefaultItems)'=='' And '$(EnableDefaultXamlItems)'=='True' And '$(EnableDefaultEmbeddedResourceItems)'=='True'">True</_DefaultXamlItemsEnabled>
 	</PropertyGroup>
 
-	<Import Project="$(MSBuildThisFileDirectory)Xamarin.Forms.DefaultItems.targets" Condition="'$(_DefaultXamlItemsEnabled)'=='True'" />
+	<Import Project="$(MSBuildThisFileDirectory)Xamarin.Forms.DefaultItems.targets" Condition="'$(MSBuildSDKsPath)'!=''" />
 
 	<PropertyGroup>
 		<CoreCompileDependsOn>