-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[iOS] Fix usage conflict of Title and AttributedTitle on ButtonRenderer #6944
Conversation
it looks like there's an infinite ping pong happening If you run the label gallery the bounds on the label just keeps changing back and forth If you change the LabelRenderer calls back to
it no longer does this |
7f6c35c
to
809a24e
Compare
@rmarinho take a look at the tests and let me know what you think. It's only the last set of tests that are failing and when I run them locally they run mostly fine
I'll play with it a bit more tomorrow see if I can get them running better locally |
aef84f7
to
768b0f2
Compare
@rmarinho all these same tests are failing on master But with this PR a lot less are failing :-) so I'd say this one is good to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Tests still failing.
@samhouts the iOS tests that are failing are failing on the revert as well so we're fine as far as iOS is concerned so now just need to wait for Android tests to finish Here's the PR with the char spacing reverted Same test is failing on iOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 1 test failing on iOS not related |
…er (xamarin#6944) * [iOS] Fix usage conflict of Title and AttributedTitle on ButtonRenderer * if CharacterSpacing isn't set then don't set it * remove comments * check for null
…er (xamarin#6944) * [iOS] Fix usage conflict of Title and AttributedTitle on ButtonRenderer * if CharacterSpacing isn't set then don't set it * remove comments * check for null
Description of Change
PR #5167 introduced a bug with iOS button text where it was setting a
AttributtedTitle
and theButtonLayoutManager.cs
was setting just the controlTitle
when the text was changed.API Changes
Behavioral/Visual Changes
When changing the Text button it should work, you should see the new text
Testing Procedure
There are several tests on ControlGallery that should pass with this fix, iOS should be green.
Can tests for example with test case
Bugzilla46458
after clicking the button it should readClicked
.PR Checklist