[Xamarin.Android.Build.Tasks] use designtime/build.props #1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should wait on #1930 to merge this, as I want to verify |
|
I merged #1930
…On 12 July 2018 at 21:26, Jonathan Peppers ***@***.***> wrote:
I think we should wait on #1930
<#1930> to merge this, as
I want to verify _LinkAssembliesNoShrink isn't running.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1957 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAxeeYym76LYtLFZcUb1JLmjWcs1O0cNks5uF7DrgaJpZM4VNqXK>
.
|
|
Can we rebase on master, so we get the #1930 fix in. |
dellis1972
requested changes
Jul 13, 2018
| @@ -305,6 +305,7 @@ Copyright (C) 2011-2012 Xamarin. All rights reserved. | |||
| <_AndroidSequencePointsMode Condition=" '$(_AndroidSequencePointsMode)' == ''">None</_AndroidSequencePointsMode> | |||
| <_InstantRunEnabled Condition=" '$(_InstantRunEnabled)' == '' ">False</_InstantRunEnabled> | |||
| <_AndroidBuildPropertiesCache>$(IntermediateOutputPath)build.props</_AndroidBuildPropertiesCache> | |||
| <_AndroidDesignTimeBuildPropertiesCache>$(IntermediateOutputPath)designtimebuild.props</_AndroidDesignTimeBuildPropertiesCache> | |||
There was a problem hiding this comment.
I know its just a file however I would place this in the designtime folder like the other files. This keeps it completely isolated.
There was a problem hiding this comment.
The problem I was having was that $(_AndroidDesignTimeResDirIntermediate) was defined later.
I can probably move things around to get this to work.
|
The problem I'm having now is Something due to |
jonathanpeppers
force-pushed
the
designtimebuild.props
branch
from
df00b0f to
4898245
Compare
|
I think
|
jonathanpeppers
changed the title
jonathanpeppers
force-pushed
the
designtimebuild.props
branch
from
4898245 to
9bb5298
Compare
Fixes: dotnet#1958 Context: dotnet#1933 Context: dotnet#1943 One of the issues I noticed while debugging the issue with dotnet#1933 is that `$(IntermediateOutputPath)build.props` gets invalidated if `$(DesignTimeBuild)` changes. `build.props` triggers alot of targets to build completely again, so this is pretty bad for our build times in an IDE... Design-Time Builds can run quite frequently in VS Windows, and we don't want to rebuild a bunch of things unnecessarily when the user switches back to a regular build. So a solution, is to use a `obj/Debug/designtime/build.props` that works independantly of `build.props`. This prevents some slower targets from running when they shouldn't, such as `_UpdateAndroidResgen`. I added a test to validate these changes, which also verify that `IncrementalClean` isn't deleting these files. It also is important to point out that any files in the `designtime` directory are not deleted during a `Clean`. Context on this here: dotnet@34a3774 Other changes: - Updated `.gitignore` for `*.binlog` - Renamed `_AndroidDesignTimeResDirIntermediate` to `_AndroidIntermediateDesignTimeBuildDirectory` and declared it earlier in `Xamarin.Android.Common.targets`
jonathanpeppers
force-pushed
the
designtimebuild.props
branch
from
9bb5298 to
6fa4a61
Compare
dellis1972
approved these changes
Jul 19, 2018
|
I'm hitting this issue on my instant run since I updated x-a to the latest master. I'll give this a another review and merge if it looks ok |
jonpryor
pushed a commit
that referenced
this pull request
Aug 3, 2018
Fixes: #1958 Context: #1933 Context: #1943 One of the issues I noticed while debugging the issue with #1933 is that `$(IntermediateOutputPath)build.props` gets invalidated if `$(DesignTimeBuild)` changes. `build.props` triggers alot of targets to build completely again, so this is pretty bad for our build times in an IDE... Design-Time Builds can run quite frequently in VS Windows, and we don't want to rebuild a bunch of things unnecessarily when the user switches back to a regular build. So a solution, is to use a `obj/Debug/designtime/build.props` that works independantly of `build.props`. This prevents some slower targets from running when they shouldn't, such as `_UpdateAndroidResgen`. I added a test to validate these changes, which also verify that `IncrementalClean` isn't deleting these files. It also is important to point out that any files in the `designtime` directory are not deleted during a `Clean`. Context on this here: 34a3774 Other changes: - Updated `.gitignore` for `*.binlog` - Renamed `_AndroidDesignTimeResDirIntermediate` to `_AndroidIntermediateDesignTimeBuildDirectory` and declared it earlier in `Xamarin.Android.Common.targets`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1958
Context: #1933
Context: #1943
One of the issues I noticed while debugging the issue with #1933 is
that
$(IntermediateOutputPath)build.propsgets invalidated if$(DesignTimeBuild)changes.build.propstriggers alot of targetsto build completely again, so this is pretty bad for our build times
in an IDE...
Design-Time Builds can run quite frequently in VS Windows, and we
don't want to rebuild a bunch of things unnecessarily when the user
switches back to a regular build.
So a solution, is to use a
obj/Debug/designtime/build.propsthatworks independantly of
build.props. This prevents some slowertargets from running when they shouldn't, such as
_UpdateAndroidResgen.I added a test to validate these changes, which also verify that
IncrementalCleanisn't deleting these files.It also is important to point out that any files in the
designtimedirectory are not deleted during a
Clean. Context on this here:34a3774
Other changes:
.gitignorefor*.binlog_AndroidDesignTimeResDirIntermediateto_AndroidIntermediateDesignTimeBuildDirectoryand declared itearlier in
Xamarin.Android.Common.targets