[Xamarin.Android.Build.Tasks] simplify inputs to _CompileToDalvik #2131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Look at the updated ones below |
|
Oops this is important: Fixing it... |
Recently I've been discovering more and more places where usage of
`**\*.*` can hurt the performance of our build.
In this case, the `_FindCompiledJavaFiles` target:
<Target Name="_FindCompiledJavaFiles" DependsOnTargets="_CompileJava">
<CreateItem Include="$(IntermediateOutputPath)android\bin\classes\\**\*.class">
<Output TaskParameter="Include" ItemName="_CompiledJavaFiles" />
</CreateItem>
</Target>
This target is running even in builds with no changes, so we are
*always* recursing directories and finding `*.class` files.
But since we are using a `classes.zip` file now, we don't need to
recurse and find the `*.class` files at all anymore!
I was able to remove this target completely, and change
`$(_CompileToDalvikInputs)` to use
`$(IntermediateOutputPath)android\bin\classes.zip`. Less inputs also
help build times, because MSBuild won't have to evaluate timestamps on
all the `*.class` files. It can just look at the single `classes.zip`
file.
To see the difference, a build with no changes was taking:
46 ms _FindCompiledJavaFiles 1 calls
15 ms _CompileToDalvikWithDx 1 calls
After these changes:
4 ms _CompileToDalvikWithDx 1 calls
`_FindCompiledJavaFiles` is gone completely.
I also made sure to include `_CompileJava` in
`$(_CompileToDalvikDependsOnTargets)` in place of
`_FindCompiledJavaFiles`.
jonathanpeppers
force-pushed
the
findcompiledjavafiles
branch
from
b3fce8d to
58e451b
Compare
|
After fixing the missing dependency for Updated logs here: FindCompiledJavaFiles.zip |
dellis1972
approved these changes
Sep 3, 2018
jonpryor
pushed a commit
that referenced
this pull request
Sep 5, 2018
) Recently I've been discovering more and more places where usage of `**\*.*` can hurt the performance of our build. In this case, the `_FindCompiledJavaFiles` target: <Target Name="_FindCompiledJavaFiles" DependsOnTargets="_CompileJava"> <CreateItem Include="$(IntermediateOutputPath)android\bin\classes\\**\*.class"> <Output TaskParameter="Include" ItemName="_CompiledJavaFiles" /> </CreateItem> </Target> This target is running even in builds with no changes, so we are *always* recursing directories and finding `*.class` files. But since we are using a `classes.zip` file now, we don't need to recurse and find the `*.class` files at all anymore! I was able to remove this target completely, and change `$(_CompileToDalvikInputs)` to use `$(IntermediateOutputPath)android\bin\classes.zip`. Less inputs also help build times, because MSBuild won't have to evaluate timestamps on all the `*.class` files. It can just look at the single `classes.zip` file. To see the difference, a build with no changes was taking: 46 ms _FindCompiledJavaFiles 1 calls 15 ms _CompileToDalvikWithDx 1 calls After these changes: 4 ms _CompileToDalvikWithDx 1 calls `_FindCompiledJavaFiles` is gone completely. I also made sure to include `_CompileJava` in `$(_CompileToDalvikDependsOnTargets)` in place of `_FindCompiledJavaFiles`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I've been discovering more and more places where usage of
**\*.*can hurt the performance of our build.In this case, the
_FindCompiledJavaFilestarget:This target is running even in builds with no changes, so we are
always recursing directories and finding
*.classfiles.But since we are using a
classes.zipfile now, we don't need torecurse and find the
*.classfiles at all anymore!I was able to remove this target completely, and change
$(_CompileToDalvikInputs)to use$(IntermediateOutputPath)android\bin\classes.zip. Less inputs alsohelp build times, because MSBuild won't have to evaluate timestamps on
all the
*.classfiles. It can just look at the singleclasses.zipfile.
To see the difference, a build with no changes was taking:
After these changes:
_FindCompiledJavaFilesis gone completely.I also made sure to include
_CompileJavain$(_CompileToDalvikDependsOnTargets)in place of_FindCompiledJavaFiles.