[Xamarin.Android.Build.Tasks] should Dispose AssemblyDefinition #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewing our codebase, we found a place where the `BuildApk` task was
calling an overload for `MonoAndroidHelper.IsReferenceAssembly`.
This presented two problems:
1. It was using the `InMemory` option
2. We were not calling `Dispose()`!
Case No.1 was bad, since we basically load every assembly into memory!
foreach (ITaskItem assembly in ResolvedUserAssemblies) {
if (MonoAndroidHelper.IsReferenceAssembly (assembly.ItemSpec)) {
//...
foreach (ITaskItem assembly in ResolvedFrameworkAssemblies) {
if (MonoAndroidHelper.IsReferenceAssembly (assembly.ItemSpec)) {
Likewise, we need to call `Dispose` here, since a lock could be held
on the file here on Windows.
The changes here made `BuildApk` slower (and more correct!), but the
overall build time better.
Before:
5890 ms BuildApk 1 calls
Time Elapsed 00:01:02.59
After:
6377 ms BuildApk 1 calls
Time Elapsed 00:00:59.37
I think the `AssemblyDefinition` instances must have been getting
cleaned up later in the build by the GC (if we were lucky), and also
used *a lot* more memory. This would contribute to overall build time.
|
Logs here: AssemblyDefinitionDispose.zip |
StephaneDelcroix
approved these changes
Sep 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewing our codebase, we found a place where the
BuildApktask wascalling an overload for
MonoAndroidHelper.IsReferenceAssembly.This presented two problems:
InMemoryoptionDispose()!Case No.1 was bad, since we basically load every assembly into memory!
Likewise, we need to call
Disposehere, since a lock could be heldon the file here on Windows.
The changes here made
BuildApkslower (and more correct!), but theoverall build time better.
Before:
After:
I think the
AssemblyDefinitioninstances must have been gettingcleaned up later in the build by the GC (if we were lucky), and also
used a lot more memory. This would contribute to overall build time.