[Xamarin.Android.Build.Tasks] remove unused Inputs/Outputs #2309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing our MSBuild targets, I noticed three targets that
declared
Inputs
andOutputs
, but did not actually update anyfiles:
_CollectConfigFiles
_CollectMdbFiles
_CollectPdbFiles
This means that MSBuild was unnecessarily looking at files to see if
they exist, and might be comparing timestamps as well. The targets
would also always run, so it doesn't matter to have
Inputs
andOutputs
in these targets at all!I basically removed these
Inputs
andOutputs
, and saw aperformance gain with just doing that. I also saw performance gains to
targets that depend on these three targets. Since
Inputs
andOutputs
timing is internal to MSBuild, I am not sure where theactual time is being tallied here.
A total of ~46ms
A total of ~10ms
An overall improvement of ~36ms.
This was the
samples/HelloWorld
project in this repo, a build withno changes. I suspect the improvement would be even better for larger
projects.