[Xamarin.Android.Build.Tasks] ResolveLibraryProjectImports temp files #2540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
approved these changes
Dec 17, 2018
|
Not going to merge since we do not have any build system atm :/ |
|
build |
When reviewing `ResolveLibraryProjectImports`, I noticed a few things
we could improve:
1. We are using `GetResourceData` to get the entire contents of a file
as a `byte[]` and then writing to disk.
2. We are writing temporary zip files to disk, reading them to extract,
then deleting them.
The first thing I did was take advantage of the `GetResourceStream`
method, so we could just do `stream.CopyTo(file)`. This prevents us
from allocating big `byte[]` the size of each file.
Next, I took advantage of `ZipArchive.Open (stream)` and
`GetResourceStream` to avoid the need for creating temporary zip
files. We can unzip directly from the `Stream` in memory.
~~ Results ~~
When timing these changes, I used the Xamarin.Forms integration
project in this repo:
Before
1. 1793 ms ResolveLibraryProjectImports 1 calls
2. 1780 ms ResolveLibraryProjectImports 1 calls
3. 1770 ms ResolveLibraryProjectImports 1 calls
After
1. 1750 ms ResolveLibraryProjectImports 1 calls
2. 1740 ms ResolveLibraryProjectImports 1 calls
3. 1702 ms ResolveLibraryProjectImports 1 calls
I would say the improvements here are around 50ms.
jonathanpeppers
force-pushed
the
resolvelibraryprojectimports-tempfiles
branch
from
aeda0e2 to
bebb5ea
Compare
jonathanpeppers
added a commit
that referenced
this pull request
Jan 2, 2019
…#2540) When reviewing the `<ResolveLibraryProjectImports/>` task, I noticed a few things we could improve: 1. We are using `GetResourceData()` to get the entire contents of a file as a `byte[]` and then writing to disk. 2. We are writing temporary zip files to disk, reading them to extract, then deleting them. The first thing I did was take advantage of the `GetResourceStream()` method, so we could just do `stream.CopyTo(file)`. This prevents us from allocating big `byte[]` the size of each file. Next, I took advantage of `ZipArchive.Open(stream)` and `GetResourceStream()` to avoid the need for creating temporary zip files. We can unzip directly from the `Stream` in memory. ~~ Results ~~ When timing these changes, I used the Xamarin.Forms integration project in this repo: Before 1. 1793 ms ResolveLibraryProjectImports 1 calls 2. 1780 ms ResolveLibraryProjectImports 1 calls 3. 1770 ms ResolveLibraryProjectImports 1 calls After 1. 1750 ms ResolveLibraryProjectImports 1 calls 2. 1740 ms ResolveLibraryProjectImports 1 calls 3. 1702 ms ResolveLibraryProjectImports 1 calls I would say the improvements here are around 50ms.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reviewing
ResolveLibraryProjectImports, I noticed a few thingswe could improve:
GetResourceDatato get the entire contents of a fileas a
byte[]and then writing to disk.then deleting them.
The first thing I did was take advantage of the
GetResourceStreammethod, so we could just do
stream.CopyTo(file). This prevents usfrom allocating big
byte[]the size of each file.Next, I took advantage of
ZipArchive.Open (stream)andGetResourceStreamto avoid the need for creating temporary zipfiles. We can unzip directly from the
Streamin memory.Results
When timing these changes, I used the Xamarin.Forms integration
project in this repo:
I would say the improvements here are around 50ms.