Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.NET 6] Replace reflection usage when setting up linker pipeline #10415

Closed
rolfbjarne opened this issue Jan 13, 2021 · 1 comment
Closed

[.NET 6] Replace reflection usage when setting up linker pipeline #10415

rolfbjarne opened this issue Jan 13, 2021 · 1 comment
Labels
dotnet An issue or pull request related to .NET (6) dotnet-pri3 .NET 6: wishlist for stable release enhancement The issue or pull request is an enhancement estimate-4h iOS Issues affecting iOS macOS Issues affecting macOS
Milestone

Comments

@rolfbjarne
Copy link
Member

rolfbjarne commented Jan 13, 2021

Context:

List<IStep> _steps;
public List<IStep> Steps {
get {
if (_steps == null) {
var pipeline = typeof (LinkContext).GetProperty ("Pipeline").GetGetMethod ().Invoke (Context, null);
_steps = (List<IStep>) pipeline.GetType ().GetField ("_steps", BindingFlags.Instance | BindingFlags.NonPublic).GetValue (pipeline);
}
return _steps;
}
}

This reflection usage should be removed at some point.

Ref (Android): dotnet/android#4709

@rolfbjarne rolfbjarne added enhancement The issue or pull request is an enhancement macOS Issues affecting macOS iOS Issues affecting iOS dotnet An issue or pull request related to .NET (6) labels Jan 13, 2021
@rolfbjarne rolfbjarne added this to the .NET 6 milestone Jan 13, 2021
@rolfbjarne rolfbjarne added dotnet-pri1 .NET 6: important for stable release estimate-2d estimate-4h dotnet-pri3 .NET 6: wishlist for stable release and removed estimate-2d dotnet-pri1 .NET 6: important for stable release labels Feb 3, 2021
@spouliot
Copy link
Contributor

removed with #11739

@ghost ghost locked as resolved and limited conversation to collaborators Apr 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dotnet An issue or pull request related to .NET (6) dotnet-pri3 .NET 6: wishlist for stable release enhancement The issue or pull request is an enhancement estimate-4h iOS Issues affecting iOS macOS Issues affecting macOS
Projects
None yet
Development

No branches or pull requests

2 participants