Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link away calls to Runtime.RegisterEntryAssembly when the dynamic registrar has been optimized away #10457

Open
rolfbjarne opened this issue Jan 18, 2021 · 0 comments
Open

Link away calls to Runtime.RegisterEntryAssembly when the dynamic registrar has been optimized away #10457

rolfbjarne opened this issue Jan 18, 2021 · 0 comments
Labels
app-size enhancement The issue or pull request is an enhancement
Milestone
.NET 10

Comments

@rolfbjarne
Copy link
Member

rolfbjarne commented Jan 18, 2021 •
edited
Loading

As the description says: link away calls to Runtime.RegisterEntryAssembly when building for device the dynamic registrar has been optimized away.

And enable link all's Runtime_RegisterEntryAssembly test.

Ref: #12330.
Ref: #11858.
@rolfbjarne rolfbjarne added enhancement The issue or pull request is an enhancement iOS Issues affecting iOS dotnet An issue or pull request related to .NET (6) labels Jan 18, 2021
@rolfbjarne rolfbjarne added this to the .NET 6 milestone Jan 18, 2021
@rolfbjarne rolfbjarne mentioned this issue Jan 18, 2021
Closed
@rolfbjarne rolfbjarne added dotnet-pri1 .NET 6: important for stable release estimate-3d labels Feb 3, 2021
@spouliot spouliot mentioned this issue May 7, 2021
Open
@spouliot spouliot self-assigned this May 31, 2021
spouliot pushed a commit to spouliot/xamarin-macios that referenced this issue Jun 7, 2021
[dotnet][linker] Remove Runtime.RegisterEntryAssembly implementatio…
cd42006 
…n on devices

Unlike _legacy_ the method becomes an empty _stub_ and is not removed.
IOW the metadata still exists... and that requires updating the tests.

Fixes dotnet#10457
@spouliot spouliot mentioned this issue Jun 7, 2021
Closed
@rolfbjarne rolfbjarne changed the title [.NET 6] Link away calls to Runtime.RegisterEntryAssembly when building for device [.NET 6] Link away calls to Runtime.RegisterEntryAssembly when the dynamic registrar has been optimized away Aug 4, 2021
@spouliot spouliot removed their assignment Sep 14, 2021
@rolfbjarne rolfbjarne modified the milestones: .NET 6, .NET 7 Jan 25, 2022
@rolfbjarne rolfbjarne removed the dotnet-pri1 .NET 6: important for stable release label Jan 25, 2022
@rolfbjarne rolfbjarne modified the milestones: .NET 7, .NET 8 Aug 26, 2022
@rolfbjarne rolfbjarne changed the title [.NET 6] Link away calls to Runtime.RegisterEntryAssembly when the dynamic registrar has been optimized away Link away calls to Runtime.RegisterEntryAssembly when the dynamic registrar has been optimized away Aug 26, 2022
@rolfbjarne rolfbjarne modified the milestones: .NET 8, .NET 9 Sep 12, 2023
@github-project-automation github-project-automation bot moved this to Technical Debt in .NET 9 Aug 27, 2024
@rolfbjarne rolfbjarne modified the milestones: .NET 9, .NET 10 Sep 27, 2024
@rolfbjarne rolfbjarne removed this from .NET 9 Sep 27, 2024
@rolfbjarne rolfbjarne added app-size and removed iOS Issues affecting iOS dotnet An issue or pull request related to .NET (6) estimate-3d labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app-size enhancement The issue or pull request is an enhancement
Projects
None yet
Milestone
.NET 10
2 participants
@rolfbjarne @spouliot