Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update xamarin-macios to consume zlib-ng from dotnet/runtime #20811

Closed
carlossanlop opened this issue Jul 3, 2024 · 2 comments
Closed
Labels
feature A feature to be implemented
Milestone

Comments

@carlossanlop
Copy link

carlossanlop commented Jul 3, 2024

The dotnet/runtime repo has migrated from consuming madler/zlib and zlib-intel to consuming zlib-ng. We merged this PR on 7/2 to achieve that: dotnet/runtime#101465

The main issue tracking this migration effort is dotnet/runtime#101465

In consequence, xamarin-macios and xamarin-android might need to make changes to ensure they retarget their dependencies appopriately.

Note: We ensured that mobile platforms find and consume the system-installed zlib, but are going to delete the zlib and zlib-intel references from the repo. So please help determine if you need to take actions on this repo.

This needs to be done before .NET 9 gets published.

Please let @carlossanlop or @akoeplinger know if you have any questions.

@rolfbjarne rolfbjarne added this to the .NET 9 milestone Jul 3, 2024
@rolfbjarne rolfbjarne added the feature A feature to be implemented label Jul 3, 2024
@rolfbjarne
Copy link
Member

We don't consume zlib ourselves, we only link with it:

<!-- Mono requires zlib, iconv, and the "Compression framework" -->
<_MainLinkerFlags Include="-lz" />

so I don't think we'll have to do much, if anything, here.

Leaving open until we've gotten the change from .NET though.

@rolfbjarne
Copy link
Member

Closing, everything seems to be working fine.

@github-project-automation github-project-automation bot moved this from .NET catchup to Done in .NET 9 Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A feature to be implemented
Projects
Status: Done
Development

No branches or pull requests

2 participants