Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

add ci_id_token_sub_claim_components to editProjectOptions #2072

Closed
wants to merge 1 commit into from

Conversation

duncan485
Copy link

This adds the ci_id_token_sub_claim_components to the gitlab project.

Note that it is currently only possible to edit this setting, so I did not add in the createProjectOptions (awaiting API implementation from gitlab: https://gitlab.com/gitlab-org/gitlab/-/issues/477260 ).

Also see https://gitlab.com/gitlab-org/gitlab/-/issues/360592#note_2060395819

@RicePatrick
Copy link
Contributor

This seems a little risky -

  1. The field isn't documented as part of the official API
  2. The example posted isn't a GitLab employee (to my knowledge), so it's not necessarily a "sanctioned" workaround
  3. There's explicitly a story open to add separate API support.

It feels like we should wait until there is an official API support; the stance on this library is to not support "non-public" APIs unless there's a very compelling reason to do so.

Any thoughts here @timofurrer ?

@duncan485
Copy link
Author

Hi @RicePatrick I get what you are saying. And can't say I disagree, shall I convert this one to WIP, and revisit once the api implementation on the giltab side has been done?

@RicePatrick
Copy link
Contributor

@duncan485 - given we'll be migrating this project to gitlab.com (hopefully) tomorrow, I'd say let's close it and we can revisit it there once the gitlab side is done, yeah :)

@RicePatrick RicePatrick closed this Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants