Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove sync-exec from package.json #61

Closed
inadarei opened this issue Dec 7, 2017 · 3 comments
Closed

Please remove sync-exec from package.json #61

inadarei opened this issue Dec 7, 2017 · 3 comments

Comments

@inadarei
Copy link

inadarei commented Dec 7, 2017

Latest version of sync-exec has security vulnerability (and will most likely never be fixed):

Even though it is an optional dependency, it still freaks out nodesecurity tests.

The functionality provided by sync-exec has been available natively, and securely since Node 0.12. I hope we can agree that is archaic enough version of Node that support for it can be stopped?

@dilin-MS
Copy link

Hi, same issue here. sync-exec triggers security vulnerability.

Vulnerable versions: <= 0.6.2
Patched version: No fix
Affected versions of sync-exec use files located in /tmp/ to buffer command results before returning values. As /tmp/ is almost always set with world readable permissions, this may allow low privilege users on the system to read the results of commands run via sync-exec under a higher privilege user.

There is currently no direct patch for sync-exec, as the child_process.execSync function provided in Node.js v0.12.0 and later provides the same functionality natively.

The best mitigation currently is to update to Node.js v0.12.0 or later, and migrate all uses of sync-exec to child_process.execSync().

Could you help remove the sync-exec from package.json?

I saw the #64 someone had create a PR but was not merged into the repo. Why?

It does not look like a good idea to use @type/copy-paste-win32fix instead of @type/copy-paste simply for the optinoal dependecies's causing security alert.

Could you help remove the sync-exec from package.json?

@AndreiSoroka
Copy link

any update?

@xavi-
Copy link
Owner

xavi- commented May 26, 2023

It's been removed in 1.5.0

@xavi- xavi- closed this as completed May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants