Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #15, failing assert when reading large zip files #16

Merged
merged 2 commits into from
Mar 19, 2019
Merged

Fix #15, failing assert when reading large zip files #16

merged 2 commits into from
Mar 19, 2019

Conversation

einars
Copy link
Contributor

@einars einars commented Dec 14, 2018

No description provided.

opam fails with missing install-findlib job
bb0db0d 
...so alias it with "install"
xavierleroy
xavierleroy reviewed Dec 17, 2018
View reviewed changes
Copy link
Owner

@xavierleroy xavierleroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the investigation and the fix. Looks good to me. There's one test that you could perhaps simplify, see below. Let me know what you think.

zip.ml Show resolved Hide resolved
xavierleroy
xavierleroy approved these changes Mar 19, 2019
View reviewed changes
Copy link
Owner

@xavierleroy xavierleroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I left this PR hanging. Looks good to me. Thanks for the code. Will merge soon.

@xavierleroy xavierleroy merged commit be5c556 into xavierleroy:master Mar 19, 2019
@einars einars deleted the fix-large-files branch March 19, 2019 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavierleroy xavierleroy xavierleroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@einars @xavierleroy