Zlib.inflate: detect truncated input instead of looping
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Truncated input can cause `inflate` to produce no output and to return "not finished" infinitely. Detect this case and fail cleanly with an exception. Note: it might be enough to fail at the first time `inflate` returns "not finished but zero output produced". Here we retry a few times before failing, just in case.
xavierleroy
force-pushed
the
fix-short-inflate
branch
from
0b9a6ae to
4d4a0d5
Compare
xavierleroy
commented
Sep 14, 2024
Comment on lines
+127
to
+132
| else | ||
| (* Gotcha: truncated input can cause an infinite loop where | ||
| [inflate] doesn't produce output and never returns "finished". | ||
| Raise an error after too many calls to [inflate] that produced | ||
| no output. *) | ||
| raise(Error("Zlib.uncompress", "truncated input data")) |
There was a problem hiding this comment.
Note: it would probably suffice to report an error as soon as used_out is 0 but finished is false. Here, we're retrying a few times before failing, just in case.
2 tasks
|
Thanks, I did not have time to work on it ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #45, truncated input can cause
inflateto produce no output and to return "not finished" infinitely. This PR detects this case and fail cleanly with an exception instead of looping.Closes: #45