Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actor pagination fixes #1435

Merged
merged 2 commits into from
Nov 5, 2023
Merged

Conversation

toshski
Copy link
Contributor

@toshski toshski commented Oct 18, 2023

There is an issue if a user goes into the Actor List, selects an Actor and views the Actor Detail, then selects one of the Actors scenes and views the scene detail, then uses the Left or Right arrow to scroll through the scene images, it is also scrolling through the Actor List pages in the background.

The existing process of Jumping to Actors based on the first letter was not ideal. It would query Actors where the name is greater than that letter. This works fine, but you then only have a subset of Actors from that letter on. This has been changed to keep the full list of Actors and jump to the page that contains an Actor whose name is from that letter onwards.

@crwxaj crwxaj merged commit 9ccbff2 into xbapps:master Nov 5, 2023
1 check passed
@toshski toshski deleted the Actor_Pagination_Fixes branch November 16, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants