Bundle Upload Tester #1441
Merged
Bundle Upload Tester #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will provide an option to test uploading a bundle file and if the file contains valid Json. It does not check the Json matches the Json format expected in a bundle, just that it is valid Json.
This modification is just a precaution for bundle upload issues. While setting up test data for another mod some time ago, I received memory errors in the browser console log and had to export my data in 2 bundles (one for scenes, one for actors). Possibly caused by the addition of Actor details. Testing this mod, I don't seem to have an issue anymore, but it seemed worthwhile to still provide a function to test files before it returns or in case others have it, given the variety of setups and platforms people have.