scraper: Validate cover image for VirtualReal websites #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the covers provided by the VirtualReal websites are using a pixel format that is not compatible with golang's `image/jpeg` decoder and also with some VR players like HereSphere. It should be kinda safe to assume that if a image can't be decoded by the golang decoders it may not work in some players. This patch validates the cover images against the golang decoders, and tries to use some gallery image as cover, if no valid coner image is found. This is the only scraper I had this issue so far, but more scrapers may need the same changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the covers provided by the VirtualReal websites are using a pixel format that is not compatible with golang's
image/jpegdecoder and also with some VR players like HereSphere. It should be kinda safe to assume that if a image can't be decoded by the golang decoders it may not work in some players.This patch validates the cover images against the golang decoders, and tries to use some gallery image as cover, if no valid coner image is found.
This is the only scraper I had this issue so far, but more scrapers may need the same changes.