Added DVD-ID support for the R18dev scraper #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pl33x
commented
Jan 4, 2024
•
pl33x
commented
- Added DVD-ID support for the R18dev scraper
- Removed message in UI that FANZA content id's are required
|
I don't think it's a good idea to completely remove the message for content ids. AFAIK R18.dev doesn't have the DVD id for all scenes but always has the Content id. Maybe reformulating the sentence to something like "R18.dev scraper works best with FANZA content ID, e.g. 84vrkm00139, but DVD ID, e.g. VRKM-139, can sometimes work too" would be better. |
Updated it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.