Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Index for scene_id and Url column size changes #1571

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

toshski
Copy link
Contributor

@toshski toshski commented Jan 8, 2024

This changes adds an index to the scene_id on the scene table.
It also increases the size of the cover_url and scene_url

I added an index to the scene.scene_id when I first started using xbvr and loaded up every site with about 35-40K scenes (have since cut that back). I had slow response that was solved by adding an index to scene_id in the scene table. There didn't seem to be any need to submit it, but with recent reports of slow responses it may help. Hard to know, as the reports didn't really provide much detail. However, with plenty of queries with the scene_id, it is probably beneficial regardless.

The change also increases the sizes of cover_url and scene_url. I had one case of each over the default column size limit in mysql. They were both cases of just one character and they were one custom sites, so this isn't a big problem, although I think there has been one or two others with column size issues, so I have included them as well.

@crwxaj crwxaj merged commit d074f7e into xbapps:master Jan 15, 2024
1 check passed
@toshski toshski deleted the DB_Add_Scene_id_Index_Increase_URL_size branch January 17, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants