Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Browser Support #100

Closed
Vhostymr opened this issue May 29, 2019 · 25 comments
Closed

Brave Browser Support #100

Vhostymr opened this issue May 29, 2019 · 25 comments

Comments

@Vhostymr
Copy link

Brave is chromium based and has some small quirks. Overall seems to work really well out of the box, only having minor issues such as the search input not automatically focusing. Would be great to add official support.

Thanks!

@Poikilos
Copy link

Poikilos commented Jun 3, 2019

I don't know whether there is "official support" yet, but it seems to work fine after some cross-browser issues were resolved in the betas:

@Vhostymr
Copy link
Author

Vhostymr commented Jun 3, 2019

Correct. @nero120 asked me to make a feature request thread for people to upvote if they wanted it added officially. Then they can see how much the feature is requested by users and discern if they need to allocate the time to fixing the remaining minor issues.

@nero120
Copy link
Member

nero120 commented Jun 3, 2019

Until Brave is supported there could well be issues that are not immediately obvious, so if you want to use xBrowserSync with it make sure you take regular back ups just in case! 😄

@nero120 nero120 added this to the v1.6.0 milestone Jun 28, 2019
@yz778
Copy link

yz778 commented Jul 21, 2019

I'm using xBrowserSync across Brave (win10), Chrome (win10), and Chromium (linux) -- and happy to report that it's working well.

If you're using Brave, consider turning off Brave's sync. I've had Brave sync on while xBrowserSync was on, and experienced bookmarks duplicated and folders being partially duplicated. If I can reproduce this, i'll file a proper bug report.

@nero120
Copy link
Member

nero120 commented Jul 21, 2019

@yz778 xBrowserSync does not support using other sync tools under any circumstances, doing so will always lead to duplication as the native APIs are triggered by those sync tools which then trigger xBrowserSync.

@yz778
Copy link

yz778 commented Jul 21, 2019

@nero120, agree and understood. Suggested feature when Brave support is official -- to detect that Brave Sync is on and give a warning.

@nero120
Copy link
Member

nero120 commented Jul 21, 2019

@yz778 that's not possible unfortunately as there's no API available for any browser that can determine that. However in v1.5.0 I have included a warning to disable any active syncing tools:

image

@indig0F10w
Copy link

Greetings, just a quick feedback from a Brave user: xBrowserSync works fine for me on Windows 10 x64, Brave, Firefox and Firefox Developer Edition.

@nero120
Copy link
Member

nero120 commented Aug 27, 2019

Thanks @indig0F10w, I've switched to Brave for my main browser and xBrowserSync is working great!

@sachbearbeiter
Copy link

Cool - i will try to use it with Brave too :) Btw. thanks a lot for this wonderful app!

@lsylvain
Copy link

If thus was available for Brave on Android, specifically on Kindle Fire, it would be a great benefit. I realize that Amazon is at war with Google and has a near closed system (though not nearly as closed as Apple), but I have been able to download APKs for software such as Brave, which is the only really decent browser for the Fire. Currently there is no way to sync Brave on the Fire as there is no sync option on the Brave settings menu. Anyway, that's my two bits.

@rob4226
Copy link

rob4226 commented Jan 7, 2020

Damn on Win10 xBrowserSync was working perfectly in Brave but now just hours ago, an update of Brave came out and renamed the "Bookmarks bar" folder to "Bookmarks" and what really broke it was they nested the "Other bookmarks" folder under the "Bookmarks" folder. Now xBrowserSync does not work at all. Of course, I literally just got down customizing my self-hosted xBrowserSync app by adding the date/timestamp the bookmark was added to xBrowserSync and then displaying under each bookmark's title, the date added/timestamp in the bookmark search results. This makes it easier for me to organize my bookmarks. I just was spent hours thinking it was something I did even though it was working fine earlier and I did not make any changes but of course with my luck come to find they changed the bookmark structure.

Here is where the revamped bookmark structure is described: brave/brave-browser#5158

Maybe the author @nero120 can point me in the correct direction to update the chrome extension to be work with this new structure? It seems like it wouldn't be too difficult and actually might even make it cleaner having all the bookmarks start from a single node ("Bookmarks") instead of two, "Bookmark bar" and "Other bookmarks". I am going to try and do it myself but any insight would be greatly appreciated. I will post the code if I figure it out. I'll fork the chrome version and make the hopefully minor changes to the app in order to create a working Brave version again. Thanks!

Here are the errors after the Brave update today:

image

**Error: [10001] HttpRequestFailed**
Context
app.html
Stack Trace
js/app.min.js:1413 (logToConsole)
js/app.min.js:1396 (logError)
js/app.min.js:1715 (apiRequestFailed)
js/app.min.js:1604 (anonymous function)
js/app.min.js:140 (anonymous function)
js/app.min.js:151 ($digest)
js/app.min.js:155 ($apply)
js/app.min.js:106 (k)
js/app.min.js:111 (v)
js/app.min.js:112 (y.onload

**Missing container: other bookmarks**
Context
background.html
Stack Trace
js/background.min.js:1947 (logToConsole)
js/background.min.js:1959 (logWarning)
js/background.min.js:4494 (anonymous function)
js/background.min.js:140 (anonymous function)
js/background.min.js:151 ($digest)
js/background.min.js:154 (anonymous function)
js/background.min.js:166 (Tg.completeTask)
js/background.min.js:52 (anonymous function)

**bookmarks.sync: [10104] FailedRemoveLocalBookmarks**
Context
background.html
Stack Trace
js/background.min.js:1942 (logToConsole)
js/background.min.js:1921 (logError)
js/background.min.js:2930 (anonymous function)
js/background.min.js:140 (anonymous function)
js/background.min.js:151 ($digest)
js/background.min.js:154 (anonymous function)
js/background.min.js:166 (Tg.completeTask)
js/background.min.js:52 (anonymous function)

@nero120
Copy link
Member

nero120 commented Jan 7, 2020

@rob4226 i was afraid they would do this at some point. It will require a new platform implementation for Brave. This is no easy task even if you are familiar with the xBrowserSync code base and native apis.

I am currently finishing off v1.5.1 for release within the next couple of weeks which will bring the android app up to date. Once that's done i will start work on v1.6.0 which will implement support for remaining mainstream browsers, starting with Brave.

@rob4226
Copy link

rob4226 commented Jan 7, 2020

@nero120 Ok thanks for the response! In that case, I will just wait for v1.6.0. In the meantime, I'll just use a previous release of Brave that works. I just downgraded and I can confirm the Chrome extension works again, at least on Windows 10. For anyone else who runs into this problem, the latest release of Brave that fully works with xBrowserSync (up to v1.5.1) is v1.1.23 which can be found here https://github.com/brave/brave-browser/releases/tag/v1.1.23

After installing a prior version you have to stop Brave from auto-updating by adding an entry to your local hosts file to break the Brave update link i.e.

0.0.0.0 laptop-updates.brave.com #prevent Brave from updating to latest version

Here is a good article to follow for that: https://www.publish0x.com/random/stop-brave-browser-auto-updating-windows-xqwmgo

@nero120
Copy link
Member

nero120 commented Jan 7, 2020

Thanks for the info @rob4226!

@LaurentOngaro
Copy link

LaurentOngaro commented Jan 16, 2020

@rob4226 , I'll downgrade my version too, hoping that Brave will make sync extensions work again soon.
If not, I'll change to another browser, because cross browser syncing is really important for me (and for lots of people for sure).
I will be sad to do that, because brave is really a great alternative on many points

@ziomik
Copy link

ziomik commented Jan 19, 2020

Quote..

@nero120
Copy link
Member

nero120 commented Feb 21, 2020

Update: Brave have now resolved the missing other bookmarks issue, the fix is scheduled to be released in Brave 1.7.x. It is not yet available in the nightly build but once it is I will test it with the current version of xBrowserSync and report back.

@scudelletti
Copy link

Looks like it's working in Brave Nightly Version 1.7.10. 🎉

@nero120
Copy link
Member

nero120 commented Feb 24, 2020

Looks like it's working in Brave Nightly Version 1.7.10. 🎉

Confirmed, thanks @scudelletti!

@nero120
Copy link
Member

nero120 commented Mar 2, 2020

FYI all, version 1.7 of Brave (that will include the fix) is scheduled to be publicly released on April 28.

@rodrigoswz
Copy link

Fixed on today's update: "Version 1.7.92 Chromium: 80.0.3987.163 (Official Build) (64-bit)"

@Vhostymr
Copy link
Author

Awesome. Thanks for the update! I have been keeping tabs on this release waiting to do some testing :)

@nero120
Copy link
Member

nero120 commented Apr 15, 2020

Fixed on today's update: "Version 1.7.92 Chromium: 80.0.3987.163 (Official Build) (64-bit)"

@rodrigoswz confirmed, thanks for the heads up!

@rob4226
Copy link

rob4226 commented Apr 25, 2020

Fixed on today's update: "Version 1.7.92 Chromium: 80.0.3987.163 (Official Build) (64-bit)"

@rodrigoswz confirmed, thanks for the heads up!

Great news! I can finally upgrade from Brave v1.1.23 👍 I've been using that outdated version for months lol

@nero120 nero120 modified the milestones: v1.6.1, v1.6.0 Jul 20, 2020
@nero120 nero120 closed this as completed in bac3cb7 Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests