Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji flags in the modal are transparent on Android #513

Open
trooperandz opened this issue Jul 29, 2023 · 1 comment
Open

Emoji flags in the modal are transparent on Android #513

trooperandz opened this issue Jul 29, 2023 · 1 comment

Comments

@trooperandz
Copy link

Issue Description

Emoji flags in the country picker modal are transparent on Android (not an issue on iOS).
Note: this issue was previously opened, but it was closed and was never fixed/resolved in the codebase.

Without change:
Screenshot_20230729_120545_DV Direct

With suggested change:
Screenshot_20230729_120520_DV Direct

Steps to Reproduce / Code Snippets

On Android, render the country picker modal as described exactly in the documentation, with the emoji flags showing (the withEmoji value is true by default). Observe that the emoji flags in the modal have significant transparency, even before any press event is executed.

On iOS, render the country picker modal, same as above. Observe that the emoji flags do not have any transparency unless the press event is executed.

Adding a color style property to the emojiFlag style block in Flag.js fixes the issue:
Screenshot 2023-07-29 at 12 06 30 PM

Expected Results

On Android, the emoji flags in the country picker modal should not have any transparency until the press event occurs.

Additional Information

  • Nodejs version: 18.14.2
  • React version: 18.2.0
  • React Native version: 0.71.6
  • react-native-country-picker-modal version: 2.0.0
  • Platform(s) (iOS, Android, web, or all?): Android
  • TypeScript version: 4.8.4
@shravanbaghel
Copy link

Can I be assigned for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants