Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate using pfUnit as formal testing framework #36

Closed
JamieJQuinn opened this issue Feb 12, 2024 · 3 comments
Closed

Investigate using pfUnit as formal testing framework #36

JamieJQuinn opened this issue Feb 12, 2024 · 3 comments
Assignees
Labels
test To do with the unit test and CI

Comments

@JamieJQuinn
Copy link
Collaborator

Currently unit tests are defined as regular subroutines and run through ctest. We may get better utilities using pfunit, like better float comparison, test tagging, running tests in parallel.

@slaizet said Thibault tried this out last year and described it as "painful" so I'd like to know what benefits we might get from pfunit before ripping out our current working test framework.

@JamieJQuinn JamieJQuinn self-assigned this Feb 12, 2024
@Nanoseb
Copy link
Collaborator

Nanoseb commented Feb 16, 2024

I've used pfUnit a bit in the past, but never done the setup from scratch so I am not sure how painful that part is. I think the main advantage is being able to cleanly run test with MPI. ctest can kind of do it (#20), but it seems fairly hacky (nevermind, it seems to work well).

An other option would be to use something like lit (https://llvm.org/docs/CommandGuide/lit.html). We are using it with Paul on an other fortran project and it is fairly straightforward.

@Nanoseb Nanoseb added the test To do with the unit test and CI label Feb 16, 2024
@pbartholomew08
Copy link
Member

I've used pFUnit in the past and found it a pain to work with, I would recommend ctest over lit.

@JamieJQuinn
Copy link
Collaborator Author

@pbartholomew08 we're currently using ctest!

Considering many folks' poor experiences with pfunit, one fewer dependency to worry about, potential issues with f2008 + Nvidia's compilers, and the fact that ctest seems to be working fine for us now, I'm considering pfunit unsuitable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test To do with the unit test and CI
Projects
None yet
Development

No branches or pull requests

3 participants